copier: fix attenuation stream frames calculation #7761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iganakov
force-pushed
the
iganakov/copier/attenuation
branch
from
543bca1
to
81b8d18
Compare
btian1
reviewed
Jun 9, 2023
dnikodem
approved these changes
Jun 12, 2023
dnikodem
requested changes
Jun 12, 2023
When calculating number of frames to be attenuated in HOST copier source stream frame bytes should be used instead of sink frame bytes. E.g. in case of 24/24 bit to 24/32 bit PCM conversion using sink container size will reduce frames number by 1/4 which will lead to multiple glitches. Also attenuation has to be applied in HOST copier in playback scenario only, thus remove from do_conversion_copy() Signed-off-by: Ievgen Ganakov <[email protected]>
iganakov
force-pushed
the
iganakov/copier/attenuation
branch
from
81b8d18
to
97f23a2
Compare
dnikodem
approved these changes
Jun 13, 2023
iganakov
requested review from
RanderWang,
abonislawski and
pblaszko
as code owners
pblaszko
approved these changes
Jun 13, 2023
kv2019i
approved these changes
Jun 13, 2023
|
#7191 hit on MTL nocodec in https://sof-ci.01.org/sofpr/PR7761/build9362/devicetest/index.html, not related to this PR . Rest of checks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calculating number of frames to be attenuated in HOST copier source stream frame bytes should be used instead of sink frame bytes.
E.g. in case of 24/24 bit to 24/32 bit PCM conversion using sink container size will reduce frames number by 1/4 which will lead to multiple glitches.
Also attenuation has to be applied in HOST copier in playback scenario only, thus remove from do_conversion_copy()